HDDS-14179. StorageVolume.getCurrentUsage() should return a fixed usage.#9504
Merged
adoroszlai merged 1 commit intoapache:masterfrom Dec 15, 2025
Merged
HDDS-14179. StorageVolume.getCurrentUsage() should return a fixed usage.#9504adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
adoroszlai
approved these changes
Dec 15, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch. The change looks good.
I prefer using the more generic interface, but can see how having a more specific return type can help reasoning about the code.
Contributor
Author
|
@adoroszlai , thanks for reviewing this!
This is for HDDS-14175. Otherwise, the usages cannot be sorted reliably if they are mutable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StorageVolume.getCurrentUsage() currently returns SpaceUsageSource, which looks like a mutable source. However, the underlying implementations always return SpaceUsageSource.Fixed. If the usages are mutable, we cannot sort them or use them to do computation reliably. We need this for for HDDS-14175.
What is the link to the Apache JIRA
HDDS-14179
How was this patch tested?
By existing tests.